-
-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Ed25519 / EdDSA, with unit tests #455
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
Any blockers for this pull request? |
I hope this gets merged in, the Ed25519 algorithm is really nice! |
auvipy
approved these changes
May 24, 2020
jpadilla
pushed a commit
that referenced
this pull request
Jun 19, 2020
adamyi
pushed a commit
to adamyi/pyjwt
that referenced
this pull request
Jul 13, 2020
Closed
wasdee
added a commit
to wasdee/pyjwt
that referenced
this pull request
Nov 13, 2020
Merged
auvipy
pushed a commit
that referenced
this pull request
Nov 13, 2020
wasdee
added a commit
to wasdee/jsonwebtoken.github.io
that referenced
this pull request
Nov 14, 2020
jpadilla/pyjwt#455 jpadilla/pyjwt#531 these are some proved about the support of pyjwt eddsa.
rylanhall33
added a commit
to rylanhall33/pyjwt
that referenced
this pull request
Jun 15, 2022
xmas7
pushed a commit
to RubyOnWorld/pyjwt
that referenced
this pull request
Sep 6, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for EdDSA signing and verification using
cryptography
(version 2.6 and higher), including unit tests in theTestEd25519Algorithms
class attests/contrib/test_algorithms.py
The
Ed25519Algorithm
class supports loading private and public keys in PEM format, as well as public keys in OpenSSH format. If a private key is specified, it can be used for both signing and verification, as the public key can simply be interpolated from the private key.Ed25519 JWT functionality was verified by encoding a JWT from PyJWT, decoding it with PyJWT, and also decoding it with NodeJS's Jose.
As a second interoperability test, I also signed an EdDSA JWT from NodeJS Jose, then verified it from PyJWT to confirm bi-directional interoperability.
Generating JWT with EdDSA and verifying it in python
Taking the JWT generated in Python and verifying it with the NodeJS jose package
Generating an EdDSA JWT in NodeJS jose, and verifying it with PyJWT
NodeJS Signing EdDSA:
Python (PyJWT) verifying EdDSA JWT from NodeJS jose: